chore: change all instances of fast-dna to fast #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
awentzel,
bheston,
chrisdholt,
Falkicon,
janechu and
nicholasrice
as code owners
nicholasrice
approved these changes
Jun 25, 2020
chrisdholt
approved these changes
Jun 25, 2020
janechu
reviewed
Jun 25, 2020
|
@EisenbergEffect - Code Climate looks good, but it will break (stop reporting). As the next phase, I'll have to add the "new" project to code climate and revalidate the badge guid's are still valid. |
awentzel
approved these changes
Jun 26, 2020
|
Ok, I've reverted the cloudinary and medium changes. The code climate change is kept. |
janechu
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces instances of "FAST-DNA" or "fast-dna" with "FAST" and "fast" respectively. This is in preparation for the repo rename from "fast-dna" to "fast" as well as the rebrand.
There were several special cases that should be pointed out as part of this renaming:
@microsoft/eslint-config-fast-dnawere left in tact sincefast-dnais part of the published package name.res.cloudinary.com/fast-dna. I've changed it tores.cloudinary.com/fastin this PR but could easily change it back. /cc @awentzelhttps://medium.com/fast-dnatohttps://medium.com/fastAre we going to change that name or should I revert that? /cc @Falkicon @chrisdholt